feat: Add application service (bridges) support#394
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 50.64% 49.78% -0.86%
==========================================
Files 101 112 +11
Lines 11533 12479 +946
==========================================
+ Hits 5841 6213 +372
- Misses 5692 6266 +574 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sampaiodiego
force-pushed
the
add-application-service-support
branch
from
1fa0373 to
4ee3063
Compare
…ing batch handling
… handling in repository and service
sampaiodiego
force-pushed
the
add-application-service-support
branch
from
4ee3063 to
5bfea59
Compare
| return this.roomService.joinUser(...args); | ||
| } | ||
|
|
||
| async joinXMPPChatRoom(roomAlias: string, sender: UserID) { |
There was a problem hiding this comment.
this implementation might live somewhere else
| } | ||
|
|
||
| // this is for querying local users which does not have the server name in the username field | ||
| return this.userRepository.findByUsername(userId.split(':')[0]?.slice(1)); |
There was a problem hiding this comment.
is this really needed?
| const { registration } = appservice; | ||
|
|
||
| if (!registration.url) { | ||
| return; // No URL configured, skip |
There was a problem hiding this comment.
this should show at least a warn log? or maybe even throw an error
| // receive transactions for events in their namespaces. | ||
| const eventRouter = container.resolve(EventRouterService); | ||
| const stateService = container.resolve(StateService); | ||
| eventRouter.setRoomStateResolver(async (roomId) => { |
There was a problem hiding this comment.
make sure this is useful and needed
2 participants
No description provided.